1
Vote

Code suggestions

description

imo it's kind of issue - when you download the source code and see 1k warnings after compilation - it can scary people out of this project while it seems quite good.

1) xml code warnings (missing elements, old parameters' names, not closed tags)
2) isn't 993 the default ssl imap port rather than 465? (465 probably is ssl smtp)
3) try-catch is very slow, so instead of
try
{
BodyParsed(null, message);
}
catch (Exception)
{
// event is not supported.
}
a better solution is:
if (BodyParsed != null)
BodyParsed(null, message);
4) i had some problems with parsing email senders (I'll provide more details later)

No files are attached

comments

pmengal wrote Jan 27 at 1:43 PM

OK

jitbit wrote Jan 26 at 4:51 PM

I'll change the default ports,
I'm not sure I follow suggestion number #3 "if (BodyParsed != null)" ?? Maybe "if(message!=null)" ?